Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/997#discussion_r49228894
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
    @@ -572,7 +572,8 @@
                                                (do
                                                  (.put pending root-id [task-id
                                                                         
message-id
    -                                                                    
{:stream out-stream-id :values values}
    +                                                                    
{:stream out-stream-id 
    +                                                                     
:values (if (= true (storm-conf TOPOLOGY-DEBUG)) values nil)}
    --- End diff --
    
    I would prefer to avoid calculating if TOPOLOGY-DEBUG is true each time.  
This is code on the critical path so if we could do it once at the beginning of 
the thread function and reuse it, that would be great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to