[
https://issues.apache.org/jira/browse/STORM-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089801#comment-15089801
]
ASF GitHub Bot commented on STORM-1457:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/997#discussion_r49228894
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -572,7 +572,8 @@
(do
(.put pending root-id [task-id
message-id
-
{:stream out-stream-id :values values}
+
{:stream out-stream-id
+
:values (if (= true (storm-conf TOPOLOGY-DEBUG)) values nil)}
--- End diff --
I would prefer to avoid calculating if TOPOLOGY-DEBUG is true each time.
This is code on the critical path so if we could do it once at the beginning of
the thread function and reuse it, that would be great.
> Avoid Unnecessary caching of tuples by executor
> -----------------------------------------------
>
> Key: STORM-1457
> URL: https://issues.apache.org/jira/browse/STORM-1457
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Kishor Patil
> Assignee: Kishor Patil
>
> It looks like the pending RotatingMap is caching list of tuples for printing
> debug message, but it is not required if "topology.debug" is turned off.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
