[
https://issues.apache.org/jira/browse/STORM-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090759#comment-15090759
]
ASF GitHub Bot commented on STORM-1419:
---------------------------------------
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49267676
--- Diff: storm-core/src/jvm/backtype/storm/utils/TupleUtils.java ---
@@ -28,8 +35,21 @@ private TupleUtils() {
public static boolean isTick(Tuple tuple) {
return tuple != null
- && Constants.SYSTEM_COMPONENT_ID
.equals(tuple.getSourceComponent())
+ &&
Constants.SYSTEM_COMPONENT_ID.equals(tuple.getSourceComponent())
&&
Constants.SYSTEM_TICK_STREAM_ID.equals(tuple.getSourceStreamId());
}
+ public static Map<String, Object>
createComponentConfigByTickFreqSecs(Map<String, Object> conf, int tickFreqSecs)
{
--- End diff --
@vesense I would rename this method to 'putTickFreqencyIntoComponentConfig'
> Solr bolt should handle tick tuples
> -----------------------------------
>
> Key: STORM-1419
> URL: https://issues.apache.org/jira/browse/STORM-1419
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-solr
> Reporter: Xin Wang
> Assignee: Xin Wang
>
> Solr bolt should handle tick tuples.
> Forcing solr client commit when bolt received tick tuple.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
