[ 
https://issues.apache.org/jira/browse/STORM-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092125#comment-15092125
 ] 

ASF GitHub Bot commented on STORM-1420:
---------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/978#issuecomment-170588179
  
    @hmcl and @vesense these changes are not necessary.  I pointed out here 
https://github.com/apache/storm/pull/977#issuecomment-169101930 that the commit 
API should probably be changed, because if we force a commit, things can get 
off from each other.  Somehow that turned into this.  I am -1 on this unless we 
also get changes to the Committer API too.


> solr CountBasedCommit should reset count=0 after commited
> ---------------------------------------------------------
>
>                 Key: STORM-1420
>                 URL: https://issues.apache.org/jira/browse/STORM-1420
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-solr
>            Reporter: Xin Wang
>            Assignee: Xin Wang
>
> The variable count should reset to 0, if not so it will increase infinitely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to