[
https://issues.apache.org/jira/browse/STORM-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098808#comment-15098808
]
ASF GitHub Bot commented on STORM-1450:
---------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1016#discussion_r49781708
--- Diff:
storm-core/test/jvm/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -1083,6 +1159,15 @@ public void TestOverGuaranteeEviction() {
Assert.assertEquals("# of pending topologies", 0,
rs.getUser("bobby").getTopologiesPending().size());
Assert.assertEquals("# of attempted topologies", 0,
rs.getUser("bobby").getTopologiesAttempted().size());
Assert.assertEquals("# of invalid topologies", 0,
rs.getUser("bobby").getTopologiesInvalid().size());
+
+ LOG.info("Assignments: {}", cluster.getAssignments());
+ for (Map.Entry<String, SchedulerAssignment> entry :
cluster.getAssignments().entrySet()) {
+ LOG.info("Topology id: {}", entry.getKey());
+ for(WorkerSlot target: entry.getValue().getSlots()) {
+ LOG.info("target resources onheap: {} offheap: {} cpu:
{}", target.getAllocatedMemOnHeap(), target.getAllocatedMemOffHeap(),
target.getAllocatedCpu());
+ }
+
+ }
--- End diff --
Revert?
> Fix bugs and refactor code in ResourceAwareScheduler
> ----------------------------------------------------
>
> Key: STORM-1450
> URL: https://issues.apache.org/jira/browse/STORM-1450
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Boyang Jerry Peng
> Assignee: Boyang Jerry Peng
> Priority: Minor
>
> Code refactored:
> 1. Refactor RAS_Nodes. Pushed some of the functionality in to RAS_Nodes.
> Each RAS_Node will now be initialized with a map of all its assignments.
> Each RAS_Node will also figure out resources used and available. Removed
> unnecessary functions.
> 2. Made WorkerSlot immutable so that a scheduling strategy won't mistakenly
> modify it
> 3. Added a wrapping layer for RAS_Node to feed into scheduling strategies so
> that the semantics of what a scheduling strategy should do will be more
> clear. Each scheduling strategy shouldn't be actually assigning anything.
> The strategy should only calculate a scheduling.
> Bug fixes:
> 1. Minor bug in displaying the assigned resources for a supervisor on the UI.
> The function updateSupervisorResources was placed in the wrong place
> 2. Minor bug fix in freeing memory in RAS_Node there was some wrong math that
> was done.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
