Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1012#issuecomment-171793561
Not really specific to this pull request, but I missed it before when the
profiling functionality was originally added.
If profiling is enabled, we turn on the "Commercial Features" of the JVM:
`worker.profiler.childopts: "-XX:+UnlockCommercialFeatures
-XX:+FlightRecorder`
The current Oracle Java license [1] states:
>Some of the packages described in the Installation of Oracle Java SE
Product Editions section above install Commercial Features that are restricted
to Oracle Java SE Advanced, Oracle Java SE Advanced Desktop and/or Oracle Java
SE Suite. **This means that even if you download an Oracle Java SE package for
free under the Java BCLA, you must separately license from Oracle (and pay the
appropriate license fee) the right to use any Commercial Features, described in
Table 1-1 below, included in these packages.**
If my interpretation of the license is correct, that means users must have
purchased a license from Orace for each node that has profiling enabled. (Read
the license [1] for more information and examples.)
I think that's probably okay, but we may want to document that somewhere
(`defaults.yaml` maybe?), so users don't accidentally run afoul of Oracle's
licensing terms.
[1] http://www.oracle.com/technetwork/java/javase/terms/products/index.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
