[ 
https://issues.apache.org/jira/browse/STORM-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102097#comment-15102097
 ] 

ASF GitHub Bot commented on STORM-1466:
---------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1007#discussion_r49878490
  
    --- Diff: storm-core/pom.xml ---
    @@ -618,7 +618,7 @@
                             <relocation>
                                 <pattern>org.apache.thrift</pattern>
                                 <!-- This pattern is inconsistent for 
backwards compatibility purposes. -->
    -                            
<shadedPattern>org.apache.thrift7</shadedPattern>
    +                            
<shadedPattern>org.apache.storm.thrift</shadedPattern>
    --- End diff --
    
    @ptgoetz no?


> Move the org.apache.thrift7 namespace to something correct/sensible
> -------------------------------------------------------------------
>
>                 Key: STORM-1466
>                 URL: https://issues.apache.org/jira/browse/STORM-1466
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Kyle Nusbaum
>            Assignee: Kyle Nusbaum
>             Fix For: 1.0.0
>
>
> Thrift is still shaded to org.apache.thrift7 even though we are not using 
> Thrift 7.
> We should also add something for temporary backwards compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to