[
https://issues.apache.org/jira/browse/STORM-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106020#comment-15106020
]
ASF GitHub Bot commented on STORM-1478:
---------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1020#issuecomment-172690746
+1
Btw, there's a typo to method name, `putTickFreqencyIntoComponentConfig`
should be `putTickFrequencyIntoComponentConfig`.
We didn't have any official releases including this method and it's used
internally, I think we're fine to change its name safely.
Could you please correct a typo? Thanks!
> make bolt's getComponentConfiguration method cleaner/simpler
> ------------------------------------------------------------
>
> Key: STORM-1478
> URL: https://issues.apache.org/jira/browse/STORM-1478
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hdfs, storm-hive
> Reporter: Xin Wang
> Assignee: Xin Wang
> Priority: Minor
>
> https://github.com/apache/storm/pull/977#discussion_r49160913
> This jira follow hmcl's comment:
> {quote}
> I noticed that the body of this method is exactly the same for
> AbstractHdfsBolt. Furthermore, it's very likely that many Storm connector
> bolts will use the same code. Can you please write a helper method in
> TupleUtils and call that method here and AbstractHdfsBolt.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
