Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1027#discussion_r50189054
--- Diff:
storm-core/src/jvm/org/apache/storm/messaging/netty/KerberosSaslNettyClient.java
---
@@ -84,7 +83,7 @@ public KerberosSaslNettyClient(Map storm_conf, String
jaas_section) {
Configuration.setConfiguration(login_conf);
//now login
LOG.debug("Trying to login.");
- Login login = new Login(jaas_section, ch);
+ ZookeeperSaslLogin login = new
ZookeeperSaslLogin(jaas_section, ch);
--- End diff --
I don't really like Zookeeper being a part of this classes name. I also
don't really like Sasl in there, because even though we use it for Sasl, there
is nothing Sasl specific in it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
