[
https://issues.apache.org/jira/browse/STORM-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107619#comment-15107619
]
ASF GitHub Bot commented on STORM-1485:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1027#discussion_r50189054
--- Diff:
storm-core/src/jvm/org/apache/storm/messaging/netty/KerberosSaslNettyClient.java
---
@@ -84,7 +83,7 @@ public KerberosSaslNettyClient(Map storm_conf, String
jaas_section) {
Configuration.setConfiguration(login_conf);
//now login
LOG.debug("Trying to login.");
- Login login = new Login(jaas_section, ch);
+ ZookeeperSaslLogin login = new
ZookeeperSaslLogin(jaas_section, ch);
--- End diff --
I don't really like Zookeeper being a part of this classes name. I also
don't really like Sasl in there, because even though we use it for Sasl, there
is nothing Sasl specific in it.
> DRPC Connectivity Issues
> ------------------------
>
> Key: STORM-1485
> URL: https://issues.apache.org/jira/browse/STORM-1485
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Kishor Patil
> Assignee: Kishor Patil
>
> We need fixing following issues for DRPC
> 1. DRPCClient should not stop trying to connect to DRPC after certain fixed
> number of retries - because DRPC server may be down for longer duration.
> 2. KerberosSaslTransportPlugin uses zookeeper Login session for creating
> Thread that dies if TGT has expired - which not recoverable state. In such
> scenario, JVM should be restarted gracefully.
> 3. DRPC ReturnResults bolt Should re-retry Connection to DRPC on
> ThriftException while sending results for particular request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
