[
https://issues.apache.org/jira/browse/STORM-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108816#comment-15108816
]
ASF GitHub Bot commented on STORM-1214:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1029#discussion_r50275791
--- Diff: storm-core/src/jvm/org/apache/storm/trident/operation/Filter.java
---
@@ -19,6 +19,30 @@
import org.apache.storm.trident.tuple.TridentTuple;
+import java.util.Map;
+
+/**
+ * Filters take in a tuple as input and decide whether or not to keep that
tuple or not.
+ *
+ * If the `isKeep()` method of a Filter returns `false` for a tuple, that
tuple will be filtered out of the Stream
+ *
+ *
+ * ### Configuration
+ * If your `Filter` implementation has configuration requirements, you
will typically want to extend
+ * {@link storm.trident.operation.BaseFilter} and override the
+ * {@link storm.trident.operation.Operation#prepare(Map,
TridentOperationContext)} method to perform your custom
+ * initialization.
+
+ *
+ * @see storm.trident.Stream
+ */
--- End diff --
all the links here need to be org.apache....
> Trident API Improvements
> ------------------------
>
> Key: STORM-1214
> URL: https://issues.apache.org/jira/browse/STORM-1214
> Project: Apache Storm
> Issue Type: Bug
> Reporter: P. Taylor Goetz
> Assignee: P. Taylor Goetz
>
> There are a few idiosyncrasies in the Trident API that can sometimes trip
> developers up (e.g. when and how to set the parallelism of components). There
> are also a few areas where the API could be made slightly more intuitive
> (e.g. add Java 8 streams-like methods like {{filter()}}, {{map()}},
> {{flatMap()}}, etc.).
> Some of these concerns can be addressed through documentation, and some by
> altering the API. Since we are approaching a 1.0 release, it would be good to
> address any API changes before a major release.
> The goal of this JIRA is to identify specific areas of improvement and
> formulate an implementation that addresses them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
