Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1030#discussion_r50288346
--- Diff: storm-core/src/clj/org/apache/storm/config.clj ---
@@ -41,11 +41,30 @@
(dofor [f (seq (.getFields Config))]
(.get f nil)))
-
+;; TODO this function and its callings will be replace when nimbus and
supervisor move to Java
(defn cluster-mode
[conf & args]
(keyword (conf STORM-CLUSTER-MODE)))
+(defn sampling-rate
+ [conf]
+ (->> (conf TOPOLOGY-STATS-SAMPLE-RATE)
+ (/ 1)
+ int))
+
+;; TODO this function together with sampling-rate are to be replaced with
Java version when util.clj is in
+(defn mk-stats-sampler
+ [conf]
+ (even-sampler (sampling-rate conf)))
+
+;; TODO this function is to be replaced with Java version when util.clj is
in
+(defn read-default-config
+ []
+ (clojurify-structure (Utils/readDefaultConfig)))
--- End diff --
Either way is fine with me so long as they are not dropped.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
