[ 
https://issues.apache.org/jira/browse/STORM-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111982#comment-15111982
 ] 

ASF GitHub Bot commented on STORM-1450:
---------------------------------------

GitHub user jerrypeng opened a pull request:

    https://github.com/apache/storm/pull/1033

    Backport [STORM-1450] to Storm-1.x branch

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jerrypeng/storm STORM-1450

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1033
    
----
commit 829ea117c8b382ef72d3c5df841534b89f06dffa
Author: Boyang Jerry Peng <[email protected]>
Date:   2016-01-13T18:28:38Z

    [STORM-1450] - Fix bugs and refactor code in ResourceAwareScheduler

commit 688366902d98a7fdc17d854a33ff975c6a60ccab
Author: Boyang Jerry Peng <[email protected]>
Date:   2016-01-13T20:13:54Z

    adding an additional test and cleaning up

commit 4722c6f5d467c147996a027d00baf867cf6bc54d
Author: Boyang Jerry Peng <[email protected]>
Date:   2016-01-14T20:53:02Z

    deleting unneccessary code

commit 052941084bc7fcaee3d433d39d2bcc7a9953c69a
Author: Boyang Jerry Peng <[email protected]>
Date:   2016-01-15T05:33:28Z

    edits based on comments

commit e0e415fd10557bb79f9e0a53647086e71932429b
Author: Boyang Jerry Peng <[email protected]>
Date:   2016-01-22T06:07:20Z

    added comment on a function

----


> Fix bugs and refactor code in ResourceAwareScheduler
> ----------------------------------------------------
>
>                 Key: STORM-1450
>                 URL: https://issues.apache.org/jira/browse/STORM-1450
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Boyang Jerry Peng
>            Assignee: Boyang Jerry Peng
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> Code refactored:
> 1. Refactor RAS_Nodes. Pushed some of the functionality in to RAS_Nodes.  
> Each RAS_Node will now be initialized with a map of all its assignments.  
> Each RAS_Node will also figure out resources used and available. Removed 
> unnecessary functions.
> 2.  Made WorkerSlot immutable so that a scheduling strategy won't mistakenly 
> modify it
> 3. Added a wrapping layer for RAS_Node to feed into scheduling strategies so 
> that the semantics of what a scheduling strategy should do will be more 
> clear.  Each scheduling strategy shouldn't be actually assigning anything.  
> The strategy should only calculate a scheduling.
> Bug fixes:
> 1. Minor bug in displaying the assigned resources for a supervisor on the UI. 
> The function updateSupervisorResources was placed in the wrong place
> 2. Minor bug fix in freeing memory in RAS_Node there was some wrong math that 
> was done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to