[ 
https://issues.apache.org/jira/browse/STORM-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115336#comment-15115336
 ] 

ASF GitHub Bot commented on STORM-1227:
---------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1030#discussion_r50703615
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/testing/staticmocking/MockedConfigUtils.java
 ---
    @@ -0,0 +1,31 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version
    + * 2.0 (the "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.testing.staticmocking;
    +
    +import org.apache.storm.utils.ConfigUtils;
    +
    +public class MockedConfigUtils extends ConfigUtils implements 
AutoCloseable {
    --- End diff --
    
    > Derek's repository has a file package-info.java, which shows how to use 
it. Do I need to include that within this pull request or wait util JIRA to do 
that? @d2r @revans2
    
    For what it's worth, it is fine with me if you want to include that file in 
this pull request.


> port backtype.storm.config to java
> ----------------------------------
>
>                 Key: STORM-1227
>                 URL: https://issues.apache.org/jira/browse/STORM-1227
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Zhuo Liu
>              Labels: java-migration, jstorm-merger
>
> port backtype.storm.config to java.  There are some parts of this that for 
> convince sake may need to stay in clojure, or have clojure equivalents.
> The code that turns Config.* into clojure constants needs to stay, and 
> reading the config may need to stay in clojure until we can cleanup all of 
> the places it is used to not need the migration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to