[
https://issues.apache.org/jira/browse/STORM-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117312#comment-15117312
]
ASF GitHub Bot commented on STORM-1257:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50842866
--- Diff: storm-core/src/jvm/org/apache/storm/zookeeper/ZkEventTypes.java
---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.zookeeper;
+
+import org.apache.zookeeper.Watcher;
+
+import java.util.HashMap;
+
+public class ZkEventTypes {
+
+ private static HashMap<Watcher.Event.EventType, String> map;
+
+ static {
+ map = new HashMap<Watcher.Event.EventType, String>();
+
+ map.put(Watcher.Event.EventType.None, ":none");
+ map.put(Watcher.Event.EventType.NodeCreated, ":node-created");
+ map.put(Watcher.Event.EventType.NodeDeleted, ":node-deleted");
+ map.put(Watcher.Event.EventType.NodeDataChanged,
":node-data-changed");
+ map.put(Watcher.Event.EventType.NodeChildrenChanged,
":node-children-changed");
+
+ }
+
+ public static String getStateName(Watcher.Event.EventType type) {
--- End diff --
I would rather see this called getTypeName instead of getStateName. Of
even just getName.
> port backtype.storm.zookeeper to java
> -------------------------------------
>
> Key: STORM-1257
> URL: https://issues.apache.org/jira/browse/STORM-1257
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: John Fang
> Labels: java-migration, jstorm-merger
>
> A wrapper around zookeeper/curator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
