Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1046#discussion_r50867596
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -553,7 +553,8 @@
(catch InterruptedException e
(log-message log-prefix " interrupted.")))
(exit-code-callback (.exitValue process)))
- nil)))
+ nil)
+ :kill-fn (fn [error] (log-error (RuntimeException. ("launch
process failed..."))))))
--- End diff --
Why are we throwing away error?
What happens if this does not exit? I assume that the heartbeat monitoring
will detect it and do the right thing, but are there other places in the code
besides a worker process that we use this? Will there be problems especially
around the exit-code-callback if they are not called?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
