Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50902361
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1050,6 +1083,12 @@ public String getBackupConnectionString() throws
Exception {
}
}
+ public static void testSetupBuilder(CuratorFrameworkFactory.Builder
--- End diff --
This was originally in a separate class to separate it out only for testing
purposes. I am OK with having this here, but lest add some javadocs to say
this is only for testing. The name should give a lot of a warning, but a full
explanation would be good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
