[ 
https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119768#comment-15119768
 ] 

ASF GitHub Bot commented on STORM-1504:
---------------------------------------

GitHub user dossett opened a pull request:

    https://github.com/apache/storm/pull/1052

    STORM-1504: Add Serializer and instruction for AvroGenericRecordBolt

    This was new for me, so some questions I have:
    
    - Would be better to automatically register this serializer instead of 
providing developer instructions?
    - What's the best practice for exception handling in a serializer? Throwing 
a RunTimeException seemed like the best option.
    
    Provided this PR is accepted, I would also vote for backporting this to 
1.0.0 since the AvroGenericRecordBolt is unusable without it in a multi-worker 
topology.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dossett/storm STORM-1504

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1052.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1052
    
----
commit eda0bfa07abe07d2b77a42e3f9496ac55959c909
Author: Aaron Dossett <[email protected]>
Date:   2016-01-27T16:49:19Z

    STORM-1504: Add Serializer and instruction for AvroGenericRecordBolt

----


> AvroGenericRecordBolt will not work in a topology with multiple workers
> -----------------------------------------------------------------------
>
>                 Key: STORM-1504
>                 URL: https://issues.apache.org/jira/browse/STORM-1504
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Aaron Dossett
>            Assignee: Aaron Dossett
>            Priority: Critical
>
> It receives Avro GenericRecord objects, which leads to serialization errors 
> in a multi-worker topology.  Specifically, GenericData.Record will throw a 
> serialization error.
> A serializer for this class should be added and registered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to