Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1050#issuecomment-176632790
@ptgoetz the current filter implementation on top of each appeared like a
kludge. see
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/trident/operation/impl/FilterExecutor.java#L38.
It does not appear to emit anything but apparently its taken care at some
other level. Also `each` operation always appends the input fields to the
output fields, so I directly implemented it via the MapProcessor. I can
refactor it as you mentioned to re-use the existing code.
@satishd `each` emits input fields plus the new fileds, and the Function
interface expects the implementor to emit within the function making it less of
a pure function. map with the MapFunction interface is closer to the map
operation in other streams.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
