Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1056#discussion_r51265457
--- Diff: external/storm-kafka/src/jvm/storm/kafka/ZkState.java ---
@@ -33,20 +32,29 @@
import java.util.Map;
public class ZkState {
+
+ public static final String TRANSACTIONAL_ZOOKEEPER_SERVERS =
"transactional.zookeeper.servers";
+ public static final String TRANSACTIONAL_ZOOKEEPER_PORT =
"transactional.zookeeper.port";
+ public static final String STORM_ZOOKEEPER_SESSION_TIMEOUT =
"storm.zookeeper.session.timeout";
+ public static final String STORM_ZOOKEEPER_CONNECTION_TIMEOUT =
"storm.zookeeper.connection.timeout";
+ public static final String STORM_ZOOKEEPER_RETRY_TIMES =
"storm.zookeeper.retry.times";
+ public static final String STORM_ZOOKEEPER_RETRY_INTERVAL =
"storm.zookeeper.retry.interval";
+
+
public static final Logger LOG =
LoggerFactory.getLogger(ZkState.class);
CuratorFramework _curator;
private CuratorFramework newCurator(Map stateConf) throws Exception {
- Integer port = (Integer)
stateConf.get(Config.TRANSACTIONAL_ZOOKEEPER_PORT);
+ Integer port = (Integer)
stateConf.get(TRANSACTIONAL_ZOOKEEPER_PORT);
String serverPorts = "";
- for (String server : (List<String>)
stateConf.get(Config.TRANSACTIONAL_ZOOKEEPER_SERVERS)) {
+ for (String server : (List<String>)
stateConf.get(TRANSACTIONAL_ZOOKEEPER_SERVERS)) {
--- End diff --
I really don't understand this. Why not use Config? Is it because the
Heron does not have a copy of org.apache.storm.Config on the classpath?
Wouldn't that be the better solutions for compatibility, especially for
something core to storm like the transactional zookeeper?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
