[ 
https://issues.apache.org/jira/browse/STORM-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123855#comment-15123855
 ] 

ASF GitHub Bot commented on STORM-1257:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1047#discussion_r51290582
  
    --- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
    @@ -288,11 +289,11 @@
     (defmacro with-inprocess-zookeeper
       [port-sym & body]
       `(with-local-tmp [tmp#]
    -                   (let [[~port-sym zks#] (zk/mk-inprocess-zookeeper tmp#)]
    +                   (let [[~port-sym zks#] (Zookeeper/mkInprocessZookeeper 
tmp# nil)]
    --- End diff --
    
    It didn't I fixed it in a different way.  I made 
Zookeeper/mkInprocessZookeeper match zk/mk-inprocess-zookeeper instead of 
returning just the factory and trying to pull the port out of the factory.


> port backtype.storm.zookeeper to java
> -------------------------------------
>
>                 Key: STORM-1257
>                 URL: https://issues.apache.org/jira/browse/STORM-1257
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: John Fang
>              Labels: java-migration, jstorm-merger
>
> A wrapper around zookeeper/curator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to