[ 
https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125030#comment-15125030
 ] 

ASF GitHub Bot commented on STORM-1504:
---------------------------------------

Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1052#discussion_r51349785
  
    --- Diff: 
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/avro/ConfluentAvroSerializer.java
 ---
    @@ -0,0 +1,81 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.hdfs.avro;
    +
    +import io.confluent.kafka.schemaregistry.client.CachedSchemaRegistryClient;
    +import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient;
    +import 
io.confluent.kafka.schemaregistry.client.rest.exceptions.RestClientException;
    +import org.apache.avro.Schema;
    +
    +import java.io.BufferedReader;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.InputStreamReader;
    +
    +/**
    + *
    + */
    +public class ConfluentAvroSerializer extends AbstractAvroSerializer {
    +
    +    private SchemaRegistryClient theClient;
    +    final private String url;
    +
    +    public ConfluentAvroSerializer() throws IOException {
    +        //Empty
    --- End diff --
    
    I did a quick search to find if there are serializers which use global 
configuration. Here is one example - 
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/security/serialization/BlowfishTupleSerializer.java
    
    Here is how the serializers are initialized - 
    
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/serialization/SerializationFactory.java#L168
    
    If you have a constructor with same signature as in the 
BlowFishTupleSerializer, I am sure it should work. can you try?


> AvroGenericRecordBolt will not work in a topology with multiple workers
> -----------------------------------------------------------------------
>
>                 Key: STORM-1504
>                 URL: https://issues.apache.org/jira/browse/STORM-1504
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Aaron Dossett
>            Assignee: Aaron Dossett
>            Priority: Critical
>
> It receives Avro GenericRecord objects, which leads to serialization errors 
> in a multi-worker topology.  Specifically, GenericData.Record will throw a 
> serialization error.
> A serializer for this class should be added and registered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to