[
https://issues.apache.org/jira/browse/STORM-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130488#comment-15130488
]
ASF GitHub Bot commented on STORM-1245:
---------------------------------------
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1069#discussion_r51727964
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1374,5 +1374,61 @@ public static RuntimeException
wrapInRuntime(Exception e){
return new RuntimeException(e);
}
}
+
+ public static <T> long bitXorValsSets(java.util.Set<T> vals) {
+ long rtn = 0l;
+ for (T n : vals) {
+ rtn = bitXor(rtn, n);
+ }
+ return rtn;
+ }
+
+ public static long bitXor(Object a, Object b) {
+ long rtn;
+
+ if (a instanceof Long && b instanceof Long) {
+ rtn = ((Long) a) ^ ((Long) b);
+ return rtn;
+ } else if (b instanceof Set) {
+ long bs = bitXorValsSets((Set) b);
+ return bitXor(a, bs);
+ } else if (a instanceof Set) {
+ long as = bitXorValsSets((Set) a);
+ return bitXor(as, b);
+ } else {
+ long ai = Long.parseLong(String.valueOf(a));
+ long bi = Long.parseLong(String.valueOf(b));
+ rtn = ai ^ bi;
+ return rtn;
+ }
+ }
+
+ public static <V> List<V> mkList(V... args) {
+ ArrayList<V> rtn = new ArrayList<V>();
+ for (V o : args) {
+ rtn.add(o);
+ }
+ return rtn;
+ }
+
+ public static <V> List<V> mkList(java.util.Set<V> args) {
+ ArrayList<V> rtn = new ArrayList<V>();
+ if (args != null) {
+ for (V o : args) {
+ rtn.add(o);
+ }
+ }
+ return rtn;
+ }
+
+ public static <V> List<V> mkList(Collection<V> args) {
--- End diff --
can we call all these methods makeList, more of javaness then clojureness
> port backtype.storm.daemon.acker to java
> ----------------------------------------
>
> Key: STORM-1245
> URL: https://issues.apache.org/jira/browse/STORM-1245
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> use
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task/acker/Acker.java
> as a guide
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
