Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1071#discussion_r51755050
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -275,11 +274,11 @@
(defn do-rebalance [nimbus storm-id status storm-base]
(let [rebalance-options (:topology-action-options storm-base)]
- (.update-storm! (:storm-cluster-state nimbus)
+ (.updateStorm (:storm-cluster-state nimbus)
storm-id
- (-> {:topology-action-options nil}
+ (thriftify-storm-base (-> {:topology-action-options nil}
(assoc-non-nil :component->executors (:component->executors
rebalance-options))
- (assoc-non-nil :num-workers (:num-workers rebalance-options)))))
+ (assoc-non-nil :num-workers (:num-workers rebalance-options))))))
--- End diff --
Can we put `thriftify-storm-base` at the end of the `->` to follow suit
here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
