[ 
https://issues.apache.org/jira/browse/STORM-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131289#comment-15131289
 ] 

ASF GitHub Bot commented on STORM-1524:
---------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1075#discussion_r51800370
  
    --- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
    @@ -140,6 +140,12 @@
         public static final String STORM_META_SERIALIZATION_DELEGATE = 
"storm.meta.serialization.delegate";
     
         /**
    +     * A list of daemon statistics  reporter plugin class names.
    +     */
    +    @isStringList
    +    public static final String 
STORM_STATISTICS_PREPARABLE_REPORTER_PLUGINS = 
"storm.statistics.preparable.reporter.plugins";
    --- End diff --
    
    Reposting since github ate my comment:
    
    Not sure myself, but how about `storm.daemon.metrics.reporter.plugins` ?
    
    Wanted to specify that this was for daemon metrics and make it plural.



> Make Storm daemon function statistics reporter pluggable
> --------------------------------------------------------
>
>                 Key: STORM-1524
>                 URL: https://issues.apache.org/jira/browse/STORM-1524
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>    Affects Versions: 0.10.0, 1.0.0, 0.10.1
>            Reporter: Kishor Patil
>            Assignee: Kishor Patil
>
> We use codahale, metrics-clojure to gather daemon side stats, but currently 
> the we have only three reporters available which use builder pattern. So it 
> would be useful to have ability to plugin different reporters that can use 
> configuration instead of builder pattern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to