Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1077#discussion_r51973468
--- Diff:
storm-core/src/clj/org/apache/storm/cluster_state/zookeeper_state_factory.clj
---
@@ -144,7 +145,7 @@
(let [curator-listener (reify ConnectionStateListener
(stateChanged
[this client newState]
- (.stateChanged listener client
newState)))]
+ (.stateChanged listener
(StormConnectionStateConverter/convert newState))))]
--- End diff --
In this line, listener is ClusterStateListener which was introduced to
unify interfaces between Zookeeper and Pacemaker.
Method signature of ClusterStateLister.stateChanged() is
`void stateChanged(org.apache.storm.cluster.ConnectionState newState)`,
while ConnectionStateListener.stateChanged() is
`void stateChanged(org.apache.curator.framework.CuratorFramework client,
org.apache.curator.framework.state.ConnectionState newState)`
So it should remove client from parameter, and convert ConnectionState from
Curator to ConnectionState from Storm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
