GitHub user HeartSaVioR reopened a pull request:
https://github.com/apache/storm/pull/1082
STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may
appear "Offline"
First of all, AFAIK, it's just an issue of API output, and it doesn't hurt
functionality although we don't fix it.
* when determining nimbus addresses from nimbus.seeds, filter out localhost
addresses
* localhost address: 127.0.0.1, localhost, 0:0:0:0:0:0:0:1
* there may be a chance that nimbus (localhost) is not reachable so we
can't get info from alive-nimbuses
* but it means ui process itself can't reach nimbus so we can ignore this
case
* there may be another change that user writes nimbus.seeds both
unreachable localhost address and other reachable nimbuses fqdn
* ui process can reach other nimbus and localhost itself is lost
* but I think we can treat it as configuration error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1492
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1082.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1082
----
commit 125fd47a7c428e5747ca2cb11fe31ad129311aa3
Author: Jungtaek Lim <[email protected]>
Date: 2016-02-05T06:40:16Z
STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may
appear "Offline"
* when determining nimbus addresses from nimbus.seeds, filter out localhost
addresses
* localhost address: 127.0.0.1, localhost, 0:0:0:0:0:0:0:1
* there may be a chance that nimbus (localhost) is not reachable so we
can't get info from alive-nimbuses
* but it means ui process itself can't reach nimbus so we can ignore this
case
* there may be another change that user writes nimbus.seeds both
unreachable localhost address and other reachable nimbuses fqdn
* ui process can reach other nimbus and localhost itself is lost
* but I think we can treat it as configuration error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
