Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1053#discussion_r52045815
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
    @@ -344,6 +348,12 @@
        :sync-retry (atom 0)
        :download-lock (Object.)
        :stormid->profiler-actions (atom {})
    +   :cgroup-manager (if (conf STORM-CGROUP-ENABLE)
    --- End diff --
    
    Also, why do we only load the isolation plugin if cgroups is enabled? Maybe 
this config can go away and we can just check if 
`storm.resource.isolation.plugin` is set?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to