[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134624#comment-15134624
]
ASF GitHub Bot commented on STORM-1336:
---------------------------------------
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52052852
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -301,7 +303,9 @@
(try
(rmpath (ConfigUtils/workerPidPath conf id pid))
(catch Exception e)))) ;; on windows, the supervisor may still
holds the lock on the worker directory
- (try-cleanup-worker conf id))
+ (try-cleanup-worker conf id)
+ (if (conf STORM-CGROUP-ENABLE)
+ (.shutDownWorker (:cgroup-manager supervisor) id false)))
--- End diff --
I would move check and call for `shutdownWorker` under `try-cleanup-worker`
method itself. Also, we can check if `(not-nil? (:cgroup-manger supervisor) )`.
> Evalute/Port JStorm cgroup support
> ----------------------------------
>
> Key: STORM-1336
> URL: https://issues.apache.org/jira/browse/STORM-1336
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Boyang Jerry Peng
> Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
