Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52070982
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1062,9 +1072,15 @@
(add-to-classpath [stormjar])
(add-to-classpath topo-classpath))
top-gc-opts (storm-conf TOPOLOGY-WORKER-GC-CHILDOPTS)
- mem-onheap (if (and mem-onheap (> mem-onheap 0)) ;; not nil and
not zero
- (int (Math/ceil mem-onheap)) ;; round up
+ mem-onheap (if (and (.get_mem_on_heap resources) (>
(.get_mem_on_heap resources) 0)) ;; not nil and not zero
+ (int (Math/ceil (.get_mem_on_heap resources))) ;;
round up
(storm-conf WORKER-HEAP-MEMORY-MB)) ;; otherwise
use default value
+ mem-offheap (if (.get_mem_off_heap resources)
+ (int (Math/ceil (.get_mem_off_heap resources))) ;;
round up
+ 0)
+
+ cpu (int (Math/ceil (.get_cpu resources)))
--- End diff --
Is the "cpu" resource already validated, or do we need to check its values
here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
