[ 
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135101#comment-15135101
 ] 

ASF GitHub Bot commented on STORM-1336:
---------------------------------------

Github user kishorvpatil commented on the pull request:

    https://github.com/apache/storm/pull/1053#issuecomment-180583768
  
    Secondly, I don't necessarily like the idea of `ResourceIsolationInterface` 
taking up responsibility for starting and stopping workers.. This would be 
moving a lot of responsibility from supervisor to `ResourceIsolationInterface` 
specially when we do a lot of setting-up/tearing-down for worker and use 
worker-launcher in multitenant cases. I would have simple interface which may 
help us call from within supervisor - and possibly more than once..- without 
any side-effects so that we may call them again in case of partial failures.
    ```
    public interface ResourceAllocationInterface {
    boolean reserveResourcesForWorker(workerid, resources);
    boolean releaseResourcesForWorker(workerid);
    ```


> Evalute/Port JStorm cgroup support
> ----------------------------------
>
>                 Key: STORM-1336
>                 URL: https://issues.apache.org/jira/browse/STORM-1336
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Boyang Jerry Peng
>              Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using 
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to