[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138524#comment-15138524
]
ASF GitHub Bot commented on STORM-1336:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52278203
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,222 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.container.cgroup;
+
+import org.apache.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.FileReader;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+public class CgroupCenter implements CgroupOperation {
+
+ private static Logger LOG =
LoggerFactory.getLogger(CgroupCenter.class);
+
+ private static CgroupCenter instance;
+
+ private CgroupCenter() {
+
+ }
+
+ public synchronized static CgroupCenter getInstance() {
+ if (instance == null) {
+ instance = new CgroupCenter();
+ }
+ return CgroupUtils.enabled() ? instance : null;
+ }
+
+ @Override
+ public List<Hierarchy> getHierarchies() {
+
+ Map<String, Hierarchy> hierarchies = new HashMap<String,
Hierarchy>();
+
+ try (FileReader reader = new
FileReader(CgroupUtils.MOUNT_STATUS_FILE);
+ BufferedReader br = new BufferedReader(reader)) {
+ String str = null;
+ while ((str = br.readLine()) != null) {
+ String[] strSplit = str.split(" ");
+ if (!strSplit[2].equals("cgroup")) {
+ continue;
+ }
+ String name = strSplit[0];
+ String type = strSplit[3];
+ String dir = strSplit[1];
+ Hierarchy h = new Hierarchy(name,
CgroupUtils.getSubSystemsFromString(type), dir);
+ hierarchies.put(type, h);
+ }
+ return new ArrayList<Hierarchy>(hierarchies.values());
+ } catch (Exception e) {
+ LOG.error("Get hierarchies error {}", e);
+ }
+ return null;
+ }
+
+ @Override
+ public Set<SubSystem> getSubSystems() {
+
+ Set<SubSystem> subSystems = new HashSet<SubSystem>();
+
+ try (FileReader reader = new
FileReader(CgroupUtils.CGROUP_STATUS_FILE);
+ BufferedReader br = new BufferedReader(reader)){
+ String str = null;
+ while ((str = br.readLine()) != null) {
+ String[] split = str.split("\t");
+ SubSystemType type = SubSystemType.getSubSystem(split[0]);
+ if (type == null) {
+ continue;
+ }
+ subSystems.add(new SubSystem(type,
Integer.valueOf(split[1]), Integer.valueOf(split[2]),
+ Integer.valueOf(split[3]).intValue() == 1 ? true :
false));
+ }
+ return subSystems;
+ } catch (Exception e) {
+ LOG.error("Get subSystems error {}", e);
+ }
+ return null;
+ }
+
+ @Override
+ public boolean isSubSystemEnabled(SubSystemType subSystemType) {
+
+ Set<SubSystem> subSystems = this.getSubSystems();
+ for (SubSystem subSystem : subSystems) {
+ if (subSystem.getType() == subSystemType) {
+ return true;
+ }
+ }
+ return false;
+ }
+
+ @Override
+ public Hierarchy getHierarchyWithSubSystem(SubSystemType subSystem) {
+ return getHierarchyWithSubSystems(Arrays.asList(subSystem));
+ }
+
+ @Override
+ public Hierarchy getHierarchyWithSubSystems(List<SubSystemType>
subSystems) {
+ List<Hierarchy> hierarchies = this.getHierarchies();
+ for (Hierarchy hierarchy : hierarchies) {
+ Hierarchy ret = hierarchy;
+ for (SubSystemType subSystem : subSystems) {
+ if (!hierarchy.getSubSystems().contains(subSystem)) {
+ ret = null;
+ break;
+ }
+ }
+ if (ret != null) {
+ return ret;
+ }
+ }
+ return null;
+ }
+
+ @Override
+ public boolean isMounted(Hierarchy hierarchy) {
+
--- End diff --
There is new line such as this in other functions as well. It can be
removed.
> Evalute/Port JStorm cgroup support
> ----------------------------------
>
> Key: STORM-1336
> URL: https://issues.apache.org/jira/browse/STORM-1336
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Boyang Jerry Peng
> Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
