Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52352681
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/core/DevicesCore.java ---
@@ -0,0 +1,185 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.container.cgroup.core;
+
+import org.apache.storm.container.cgroup.CgroupUtils;
+import org.apache.storm.container.cgroup.SubSystemType;
+import org.apache.storm.container.cgroup.Device;
+
+import java.io.IOException;
+import java.util.List;
+
+public class DevicesCore implements CgroupCore {
+
+ private final String dir;
+
+ public static final String DEVICES_ALLOW = "/devices.allow";
+ public static final String DEVICES_DENY = "/devices.deny";
+ public static final String DEVICES_LIST = "/devices.list";
+
+ public static final char TYPE_ALL = 'a';
+ public static final char TYPE_BLOCK = 'b';
+ public static final char TYPE_CHAR = 'c';
+
+ public static final int ACCESS_READ = 1;
+ public static final int ACCESS_WRITE = 2;
+ public static final int ACCESS_CREATE = 4;
+
+ public static final char ACCESS_READ_CH = 'r';
+ public static final char ACCESS_WRITE_CH = 'w';
+ public static final char ACCESS_CREATE_CH = 'm';
--- End diff --
Can we make these final values private? Since they are only used in this
class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
