[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140345#comment-15140345
]
ASF GitHub Bot commented on STORM-1336:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52416222
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/core/CpuacctCore.java ---
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.container.cgroup.core;
+
+import org.apache.storm.container.cgroup.CgroupUtils;
+import org.apache.storm.container.cgroup.SubSystemType;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class CpuacctCore implements CgroupCore {
+
+ public static final String CPUACCT_USAGE = "/cpuacct.usage";
+ public static final String CPUACCT_STAT = "/cpuacct.stat";
+ public static final String CPUACCT_USAGE_PERCPU =
"/cpuacct.usage_percpu";
+
+ private final String dir;
+
+ public CpuacctCore(String dir) {
+ this.dir = dir;
+ }
+
+ @Override
+ public SubSystemType getType() {
+ return SubSystemType.cpuacct;
+ }
+
+ public Long getCpuUsage() throws IOException {
+ return
Long.parseLong(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUACCT_USAGE)).get(0));
+ }
+
+ public Map<StatType, Long> getCpuStat() throws IOException {
+ List<String> strs =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir, CPUACCT_STAT));
+ Map<StatType, Long> result = new HashMap<StatType, Long>();
+ result.put(StatType.user, Long.parseLong(strs.get(0).split("
")[1]));
+ result.put(StatType.system, Long.parseLong(strs.get(1).split("
")[1]));
+ return result;
+ }
+
+ public Long[] getPerCpuUsage() throws IOException {
+ String str =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUACCT_USAGE_PERCPU)).get(0);
+ String[] strArgs = str.split(" ");
+ Long[] result = new Long[strArgs.length];
+ for (int i = 0; i < result.length; i++) {
+ result[i] = Long.parseLong(strArgs[i]);
+ }
+ return result;
+ }
+
+ public enum StatType {
--- End diff --
It is better to declare inner class,enums static.
> Evalute/Port JStorm cgroup support
> ----------------------------------
>
> Key: STORM-1336
> URL: https://issues.apache.org/jira/browse/STORM-1336
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Boyang Jerry Peng
> Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
