Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1074#discussion_r52492415
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
    @@ -98,10 +104,26 @@ public static long currentTimeMillis() {
                 return System.currentTimeMillis();
             }
         }
    -    
    +
    +    public static long secsToMillis (int secs) {
    +        return 1000*(long) secs;
    +    }
    +
    +    public static long secsToMillisLong(double secs) {
    +        return (long) (1000 * secs);
    +    }
    +
         public static int currentTimeSecs() {
             return (int) (currentTimeMillis() / 1000);
         }
    +
    +    public static int deltaSecs(int timeInSeconds) {
    +        return Time.currentTimeSecs() - timeInSeconds;
    +    }
    +
    +    public static long deltaMs(long timeInMilliseconds) {
    --- End diff --
    
    This one we need a comment on too indicating that this is from 
System.currentTimeMillis and not Simulated Time.  Not sure if we can use 
Simulated Time here or not.  If we can it makes things simpler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to