Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1092#issuecomment-182620204
-1
`RotationMap` is not a drop-in replacement for TimeCacheMap. Unless you
take care of rotating the map, it doesn't actually do anything more than a
normal map. The documentation in `RotatingMap` is actually incorrect, and I'd
support changing it in this PR.
Why is it exactly that we want to remove `TimeCacheMap`? All it is is a
thread-safe, self-rotating wrapper around `RotatingMap`, which looks convenient.
Given it's not anywhere near the critical path, I don't see a problem with
having a synchronized data structure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
