[
https://issues.apache.org/jira/browse/STORM-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141888#comment-15141888
]
ASF GitHub Bot commented on STORM-1536:
---------------------------------------
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1092#issuecomment-182620204
-1
`RotationMap` is not a drop-in replacement for TimeCacheMap. Unless you
take care of rotating the map, it doesn't actually do anything more than a
normal map. The documentation in `RotatingMap` is actually incorrect, and I'd
support changing it in this PR.
Why is it exactly that we want to remove `TimeCacheMap`? All it is is a
thread-safe, self-rotating wrapper around `RotatingMap`, which looks convenient.
Given it's not anywhere near the critical path, I don't see a problem with
having a synchronized data structure.
> Eliminate or minimize use of deprecated TimeCacheMap
> ----------------------------------------------------
>
> Key: STORM-1536
> URL: https://issues.apache.org/jira/browse/STORM-1536
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: Aaron Dossett
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
