Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52646837
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,210 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.container.cgroup;
+
+import org.apache.commons.lang.ArrayUtils;
+import org.apache.storm.Config;
+import org.apache.storm.container.ResourceIsolationInterface;
+import org.apache.storm.container.cgroup.core.CpuCore;
+import org.apache.storm.container.cgroup.core.MemoryCore;
+import org.apache.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Class that implements ResourceIsolationInterface that manages cgroups
+ */
+public class CgroupManager implements ResourceIsolationInterface {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(CgroupManager.class);
+
+ private CgroupCenter center;
+
+ private Hierarchy hierarchy;
+
+ private CgroupCommon rootCgroup;
+
+ private static String rootDir;
+
+ private Map conf;
+
+ /**
+ * initialize intial data structures
+ * @param conf storm confs
+ */
+ public void prepare(Map conf) throws IOException {
+ this.conf = conf;
+ this.rootDir = Config.getCgroupRootDir(this.conf);
+ if (this.rootDir == null) {
+ throw new RuntimeException("Check configuration file. The
storm.supervisor.cgroup.rootdir is missing.");
+ }
+
+ File file = new File(Config.getCgroupStormHierarchyDir(conf) + "/"
+ this.rootDir);
+ if (!file.exists()) {
+ LOG.error("{} is not existing.", file.getPath());
+ throw new RuntimeException("Check if cgconfig service starts
or /etc/cgconfig.conf is consistent with configuration file.");
+ }
+ this.center = CgroupCenter.getInstance();
+ if (this.center == null) {
+ throw new RuntimeException("Cgroup error, please check
/proc/cgroups");
+ }
+ this.prepareSubSystem(this.conf);
+ }
+
+ /**
+ * initalize subsystems
+ */
+ private void prepareSubSystem(Map conf) throws IOException {
+ List<SubSystemType> subSystemTypes = new LinkedList<>();
+ for (String resource : Config.getCgroupStormResources(conf)) {
+ subSystemTypes.add(SubSystemType.getSubSystem(resource));
+ }
+
+ this.hierarchy = center.getHierarchyWithSubSystems(subSystemTypes);
+
+ if (this.hierarchy == null) {
+ Set<SubSystemType> types = new HashSet<SubSystemType>();
+ types.add(SubSystemType.cpu);
+ this.hierarchy = new
Hierarchy(Config.getCgroupStormHierarchyName(conf), types,
Config.getCgroupStormHierarchyDir(conf));
+ }
+ this.rootCgroup = new CgroupCommon(this.rootDir, this.hierarchy,
this.hierarchy.getRootCgroups());
+
+ // set upper limit to how much cpu can be used by all workers
running on supervisor node.
+ // This is done so that some cpu cycles will remain free to run
the daemons and other miscellaneous OS operations.
+ CpuCore supervisorRootCPU = (CpuCore)
this.rootCgroup.getCores().get(SubSystemType.cpu);
+ setCpuUsageUpperLimit(supervisorRootCPU, ((Number)
this.conf.get(Config.SUPERVISOR_CPU_CAPACITY)).intValue());
+ }
+
+ /**
+ * User cfs_period & cfs_quota to control the upper limit use of cpu
core e.g.
--- End diff --
User -> Use
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
