Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1097#discussion_r52656904
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -487,11 +486,12 @@
)))))
(defn register-callbacks [worker]
- (log-message "Registering IConnectionCallbacks for " (:assignment-id
worker) ":" (:port worker))
- (msg-loader/register-callback (:transfer-local-fn worker)
- (:receiver worker)
- (:storm-conf worker)
- (worker-context worker)))
+ (let [transfer-local-fn (:transfer-local-fn worker)
+ ^IConnection socket (:receiver worker)]
+ (log-message "Registering IConnectionCallbacks for " (:assignment-id
worker) ":" (:port worker))
+ (.registerRecv socket (DeserializingConnectionCallback. (:storm-conf
worker)
--- End diff --
Could we just inline `DeserializingConnectionCallback`? It's only used here
and it'd be only a couple lines of Clojure. We're going to have to get rid of
Java code that references Clojure like `DeserializingConnectionCallback` does
anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
