[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144961#comment-15144961
]
ASF GitHub Bot commented on STORM-1336:
---------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52775213
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1178,7 +1212,7 @@
(FileUtils/copyDirectory (File. (.getFile url)) (File.
target-dir)))))))
(defmethod launch-worker
- :local [supervisor storm-id port worker-id mem-onheap]
+ :local [supervisor storm-id port worker-id resources]
--- End diff --
I think when I made my comment I thought we had simply added an unused
parameter, but that was not the case. Yes, we should keep things consistent as
you have done, so disregard.
> Evalute/Port JStorm cgroup support
> ----------------------------------
>
> Key: STORM-1336
> URL: https://issues.apache.org/jira/browse/STORM-1336
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Boyang Jerry Peng
> Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
