Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52782270
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/core/CpusetCore.java ---
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.container.cgroup.core;
+
+import org.apache.storm.container.cgroup.CgroupUtils;
+import org.apache.storm.container.cgroup.SubSystemType;
+
+import java.io.IOException;
+import java.util.LinkedList;
+
+public class CpusetCore implements CgroupCore {
+
+ public static final String CPUSET_CPUS = "/cpuset.cpus";
+ public static final String CPUSET_MEMS = "/cpuset.mems";
+ public static final String CPUSET_MEMORY_MIGRATE =
"/cpuset.memory_migrate";
+ public static final String CPUSET_CPU_EXCLUSIVE =
"/cpuset.cpu_exclusive";
+ public static final String CPUSET_MEM_EXCLUSIVE =
"/cpuset.mem_exclusive";
+ public static final String CPUSET_MEM_HARDWALL =
"/cpuset.mem_hardwall";
+ public static final String CPUSET_MEMORY_PRESSURE =
"/cpuset.memory_pressure";
+ public static final String CPUSET_MEMORY_PRESSURE_ENABLED =
"/cpuset.memory_pressure_enabled";
+ public static final String CPUSET_MEMORY_SPREAD_PAGE =
"/cpuset.memory_spread_page";
+ public static final String CPUSET_MEMORY_SPREAD_SLAB =
"/cpuset.memory_spread_slab";
+ public static final String CPUSET_SCHED_LOAD_BALANCE =
"/cpuset.sched_load_balance";
+ public static final String CPUSET_SCHED_RELAX_DOMAIN_LEVEL =
"/cpuset.sched_relax_domain_level";
+
+ private final String dir;
+
+ public CpusetCore(String dir) {
+ this.dir = dir;
+ }
+
+ @Override
+ public SubSystemType getType() {
+ return SubSystemType.cpuset;
+ }
+
+ public void setCpus(int[] nums) throws IOException {
+ setConfigs(nums, CPUSET_CPUS);
+ }
+
+ public int[] getCpus() throws IOException {
+ String output =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir, CPUSET_CPUS)).get(0);
+ return parseNums(output);
+ }
+
+ public void setMems(int[] nums) throws IOException {
+ setConfigs(nums, CPUSET_MEMS);
+ }
+
+ private void setConfigs(int[] nums, String config) throws IOException {
+ StringBuilder sb = new StringBuilder();
+ for (int num : nums) {
+ sb.append(num);
+ sb.append(',');
+ }
+ sb.deleteCharAt(sb.length() - 1);
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir, config),
sb.toString());
+ }
+
+ public int[] getMems() throws IOException {
+ String output =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir, CPUSET_MEMS)).get(0);
+ return parseNums(output);
+ }
+
+ public void setMemMigrate(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_MIGRATE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemMigrate() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_MIGRATE)).get(0));
+ return output > 0;
+ }
+
+ public void setCpuExclusive(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_CPU_EXCLUSIVE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isCpuExclusive() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_CPU_EXCLUSIVE)).get(0));
+ return output > 0;
+ }
+
+ public void setMemExclusive(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEM_EXCLUSIVE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemExclusive() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEM_EXCLUSIVE)).get(0));
+ return output > 0;
+ }
+
+ public void setMemHardwall(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEM_HARDWALL), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemHardwall() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEM_HARDWALL)).get(0));
+ return output > 0;
+ }
+
+ public int getMemPressure() throws IOException {
+ String output =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_PRESSURE)).get(0);
+ return Integer.parseInt(output);
+ }
+
+ public void setMemPressureEnabled(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_PRESSURE_ENABLED), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemPressureEnabled() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_PRESSURE_ENABLED)).get(0));
+ return output > 0;
+ }
+
+ public void setMemSpreadPage(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_SPREAD_PAGE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemSpreadPage() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_SPREAD_PAGE)).get(0));
+ return output > 0;
+ }
+
+ public void setMemSpreadSlab(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_SPREAD_SLAB), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemSpreadSlab() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_SPREAD_SLAB)).get(0));
+ return output > 0;
+ }
+
+ public void setSchedLoadBlance(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_SCHED_LOAD_BALANCE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isSchedLoadBlance() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_SCHED_LOAD_BALANCE)).get(0));
+ return output > 0;
+ }
+
+ public void setSchedRelaxDomainLevel(int value) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_SCHED_RELAX_DOMAIN_LEVEL), String.valueOf(value));
+ }
+
+ public int getSchedRelaxDomainLevel() throws IOException {
+ String output =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_SCHED_RELAX_DOMAIN_LEVEL)).get(0);
+ return Integer.parseInt(output);
+ }
+
+ public static int[] parseNums(String outputStr) {
+ char[] output = outputStr.toCharArray();
+ LinkedList<Integer> numList = new LinkedList<Integer>();
+ int value = 0;
+ int start = 0;
+ boolean isHyphen = false;
+ for (char ch : output) {
--- End diff --
I agree this is not the most straightforward way of doing this in Java and
looks more C-like.
I think I would be OK with leaving the code as-is, and maybe we could add a
comment explaining what this does for others since it is? We could clean it
up
in follow-on work if it still is a problem.
```
/**
* Accepts a string of comma-separated values or ranges of values. Specify
a
* value like '42' and a range like '12-17'.
*
* Example: '42,12-17,100' -> {42, 12, 13, 14, 15, 16, 17, 100}
*/
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
