Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1098#issuecomment-183464954
I didn't realize how messed up timer.clj really was. Besides fixing the
locking issues in the code, my biggest suggestion would be to make it fully
object oriented and make all of the static methods regular
methods/constructors. It is already object oriented, we just need to take it
the rest of the way. And then we can make it AutoClosable too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
