[
https://issues.apache.org/jira/browse/STORM-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146405#comment-15146405
]
ASF GitHub Bot commented on STORM-1273:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1081#discussion_r52838686
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -587,7 +586,12 @@
(defn update-heartbeats! [nimbus storm-id all-executors
existing-assignment]
(log-debug "Updating heartbeats for " storm-id " " (pr-str
all-executors))
(let [storm-cluster-state (:storm-cluster-state nimbus)
- executor-beats (.executor-beats storm-cluster-state storm-id
(:executor->node+port existing-assignment))
+ executor-beats (let [executor-stats-java-map (.executorBeats
storm-cluster-state storm-id (.get_executor_node_port (thriftify-assignment
existing-assignment)))
+ executor-stats-clojurify (clojurify-structure
executor-stats-java-map)]
+ (->> (dofor [[^ExecutorInfo executor-info
^ClusterWorkerHeartbeat cluster-worker-heartbeat] executor-stats-clojurify]
+ {[(.get_task_start executor-info)
(.get_task_end executor-info)] (clojurify-zk-worker-hb
cluster-worker-heartbeat)})
--- End diff --
with reference #diff-3dc2ee75946dae2afc9de7d4e5487219R191
in earlier version,
the structure returned was {["task_start", "task_end"] : {time-secs,
uptime, executor-stat}}
now the structure returned seems to be {["task_start", "task_end"] :
{storm-id, executor-stats, time-secs, uptime-secs}}
It seems for each executor, clojurified cluster worker heart beat is being
stored. can you confirm this is not the case?
> port backtype.storm.cluster to java
> -----------------------------------
>
> Key: STORM-1273
> URL: https://issues.apache.org/jira/browse/STORM-1273
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> current state of the cluster (Some of this moves to java as a part of
> heartbeat server)
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster
> as an example
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
