[ 
https://issues.apache.org/jira/browse/STORM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148782#comment-15148782
 ] 

Abhishek Agarwal commented on STORM-1246:
-----------------------------------------

Thanks [~revans2] I will move the translation logic to 
local_state_converter.clj. Much of the code in that file will be throwaway 
code. I am also adding methods such as these in LocalState.java
{noformat}
public void addTopologyHistory(LSTopoHistory lsTopoHistory) {
        LSTopoHistoryList lsTopoHistoryListWrapper = (LSTopoHistoryList) 
get(LS_TOPO_HISTORY);
        List<LSTopoHistory> currentTopoHistoryList = new ArrayList<>();
        if (null != lsTopoHistoryListWrapper) {
            
currentTopoHistoryList.addAll(lsTopoHistoryListWrapper.get_topo_history());
        }
        currentTopoHistoryList.add(lsTopoHistory);
        put(LS_TOPO_HISTORY, new LSTopoHistoryList(currentTopoHistoryList));
    }
{noformat}

The above can be used in clojure and later in java without any re-porting. Will 
send a PR soon. 

> port backtype.storm.local-state to java
> ---------------------------------------
>
>                 Key: STORM-1246
>                 URL: https://issues.apache.org/jira/browse/STORM-1246
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Abhishek Agarwal
>              Labels: java-migration, jstorm-merger
>
> Wrapper around LocalState, with some helper functions for converting between 
> storm and thrift.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to