[ 
https://issues.apache.org/jira/browse/STORM-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149134#comment-15149134
 ] 

Kishor Patil commented on STORM-1542:
-------------------------------------


We can change logviewer to expose the REST API to create jstack - as it might 
work. Even though it is overhead of refactoring portions of logic supervisor 
uses to find which pid to launch the jstack command. 
Not all actions are synchronous - run profiler for next 10 minutes ( needs to 
remember to shut it down/ take profiler dump before shutting down the profiler.)
It may good advice to do that for other profiling actions such as run profiler 
( which requires remembering how long to run and stop etc. - we are using 
Zookeeper for that.). Also, it is useful to have UI route all pending actions 
via ZK to supervisor - so that multiple users requesting for same action - does 
not reflect in multiple actions being taken. Currently, supervisor kind of 
merged those to single action for profiling.

[~abhishek.agarwal],
I don't see any special advantage to avoiding ZK here. Can you please elaborate 
if I am missing something?

> Taking jstack for a worker in UI results in endless empty jstack dumps
> ----------------------------------------------------------------------
>
>                 Key: STORM-1542
>                 URL: https://issues.apache.org/jira/browse/STORM-1542
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 1.0.0
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>            Priority: Critical
>
> Resolved path for jstack command on supervisor is
> /home/y/share/yjava_jdk/java/jstack which doesn't exist. command returns 127 
> as exit code. When a request for jstack dump is made from UI, a zookeeper 
> node is created. Now supervisor keeps on reading this node, executes jstack 
> command and since exit code is non-zero, doesn't delete the node afterwards. 
> Thus supervisor keeps on executing the command forever and each invocation 
> creates an new empty file.
> {noformat}
> $BINPATH/jstack $1 > "$2/${FILENAME}"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to