[
https://issues.apache.org/jira/browse/STORM-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150930#comment-15150930
]
ASF GitHub Bot commented on STORM-1255:
---------------------------------------
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53207784
--- Diff: storm-core/test/jvm/org/apache/storm/utils/TimeTest.java ---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.utils;
+
+import org.junit.Test;
+import org.junit.Assert;
+
+public class TimeTest{
+
+ @Test
+ public void secsToMillisLongTest(){
+ Assert.assertEquals(Time.secsToMillisLong(0), 0);
+ Assert.assertEquals(Time.secsToMillisLong(0.002), 2);
+ Assert.assertEquals(Time.secsToMillisLong(1), 1000);
+ Assert.assertEquals(Time.secsToMillisLong(1.08), 1080);
+ Assert.assertEquals(Time.secsToMillisLong(10), 10000);
+ Assert.assertEquals(Time.secsToMillisLong(10.1), 10100);
+ }
+
+ @Test
+ public void ifNotSimulatingIsSimulatingReturnsFalse(){
--- End diff --
Can we have better name it is bit confusing
> port backtype.storm.utils-test to java
> --------------------------------------
>
> Key: STORM-1255
> URL: https://issues.apache.org/jira/browse/STORM-1255
> Project: Apache Storm
> Issue Type: New Feature
> Components: rm-core, storm-core
> Reporter: Robert Joseph Evans
> Assignee: Alessandro Bellina
> Labels: java-migration, jstorm-merger
>
> junit test migration
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
