[ 
https://issues.apache.org/jira/browse/STORM-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152063#comment-15152063
 ] 

ASF GitHub Bot commented on STORM-1232:
---------------------------------------

Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1108#discussion_r53293242
  
    --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/EvenScheduler.java 
---
    @@ -0,0 +1,157 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.scheduler;
    +
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.Comparator;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Map.Entry;
    +import java.util.Set;
    +import java.util.TreeMap;
    +
    +import org.apache.storm.utils.Utils;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.collect.Sets;
    +
    +public class EvenScheduler implements IScheduler {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(EvenScheduler.class);
    +
    +    public static List<WorkerSlot> sortSlots(List<WorkerSlot> 
availableSlots, Cluster cluster) {
    --- End diff --
    
    It will be great if you can add some documentation in comments with an 
example list. 


> port  backtype.storm.scheduler.DefaultScheduler to java
> -------------------------------------------------------
>
>                 Key: STORM-1232
>                 URL: https://issues.apache.org/jira/browse/STORM-1232
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Xin Wang
>              Labels: java-migration, jstorm-merger
>
> port the DefaultScheduler to java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to