[ 
https://issues.apache.org/jira/browse/STORM-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152280#comment-15152280
 ] 

Abhishek Agarwal edited comment on STORM-1254 at 2/18/16 1:09 PM:
------------------------------------------------------------------

You can move (ServletHolder. (ring.util.servlet/servlet handler)) call to the 
caller clojure files and in config-filter you can pass the ServletHolder rather 
than the handler. 
e.g. line 1292 in core.clj becomes
{noformat}
(config-filter server  (ring.util.servlet/servlet app) filters-confs))}))       
                  
{noformat}
Same change will be made in logviewer.clj and drpc.clj

config-filter signature changes to 
{noformat}
(defn config-filter [server ^ServletHolder holder filters-confs])
{noformat}


was (Author: abhishek.agarwal):
You can move (ServletHolder. (ring.util.servlet/servlet handler)) call to the 
caller clojure files and in config-filter you can pass the ServletHolder rather 
than the handler. 
e.g. line 1292 in core.clj becomes
{noformat}
(ServletHolder.
 (config-filter server  (ring.util.servlet/servlet app) filters-confs))}))      
                   
{noformat}
Same change will be made in logviewer.clj and drpc.clj

config-filter signature changes to 
{noformat}
(defn config-filter [server ^ServletHolder holder filters-confs])
{noformat}

> port backtype.storm.ui.helpers to java
> --------------------------------------
>
>                 Key: STORM-1254
>                 URL: https://issues.apache.org/jira/browse/STORM-1254
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Jark Wu
>              Labels: java-migration, jstorm-merger
>
> Helper functions for the UI/HTTP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to