Github user abhishekagarwal87 commented on the pull request:

    https://github.com/apache/storm/pull/601#issuecomment-186855234
  
    Thanks for doing this Anishek. My comments
    Kafka spout should declare the stream id in output declaration. 
    ```
    declarer.declare(streamID, _spoutConfig.scheme.getOutputFields()
    ```
    I would prefer the streamID to come from the scheme. More than often the 
stream on which data is to be sent to, depends on the input data. Since scheme 
knows about the data, it can also determine the stream. This makes more sense 
when you think of multiple output streams from same spout. The only downside I 
see is that the scheme interface will change and that might translate into 
compatibility issues. Nonetheless this PR is a good start. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to