[
https://issues.apache.org/jira/browse/STORM-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157141#comment-15157141
]
ASF GitHub Bot commented on STORM-1245:
---------------------------------------
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/1069#issuecomment-187230721
+1,
The acker logic is correct, come from JStorm.
In JStorm, it handle two more case:
Acker.ACKER_INIT_STREAM_ID's tuple is after Acker.ACKER_ACK_STREAM_ID's
tuple or Acker.ACKER_FAIL_STREAM_ID's tuple.
@bastiliu , the logic handling the above two cases should also port to 1.x
branch
> port backtype.storm.daemon.acker to java
> ----------------------------------------
>
> Key: STORM-1245
> URL: https://issues.apache.org/jira/browse/STORM-1245
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> use
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task/acker/Acker.java
> as a guide
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
